iven/zclaw_openfang
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(plan): address review feedback for Phase 1 plan

Browse Source 
- Fix mock path in setup.ts to use @ alias
- Add Web Crypto polyfill for Node.js test environment
- Use pnpm exec for vitest version check
- Update Task 4.1 to note existing isLocalhost function
- Add cross-platform notes for Windows users

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
iven
2026-03-21 16:42:38 +08:00
parent 5edb8e347f
commit 60ddb0b1e9
1 changed files with 21 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
docs/superpowers/plans/2026-03-21-phase1-security-testing.md
View File

@@ -55,7 +55,12 @@ desktop/
- [ ] **Step 1: 安装 Vitest 和测试相关依赖** - [ ] **Step 1: 安装 Vitest 和测试相关依赖**
Run: Run (Windows):
```bash
cd g:\ZClaw_openfang\desktop && pnpm add -D vitest@2.1.8 @testing-library/react@16.1.0 @testing-library/jest-dom@6.6.3 jsdom@25.0.1
```
Run (Unix):
```bash ```bash
cd g:/ZClaw_openfang/desktop && pnpm add -D vitest@2.1.8 @testing-library/react@16.1.0 @testing-library/jest-dom@6.6.3 jsdom@25.0.1 cd g:/ZClaw_openfang/desktop && pnpm add -D vitest@2.1.8 @testing-library/react@16.1.0 @testing-library/jest-dom@6.6.3 jsdom@25.0.1
``` ```
@@ -66,7 +71,7 @@ Expected: 依赖安装成功
Run: Run:
```bash ```bash
cd g:/ZClaw_openfang/desktop && pnpm vitest --version cd g:\ZClaw_openfang\desktop && pnpm exec vitest --version
``` ```
Expected: 输出 `vitest/2.1.8` Expected: 输出 `vitest/2.1.8`
@@ -129,14 +134,20 @@ Create `desktop/tests/setup.ts`:
```typescript ```typescript
import '@testing-library/jest-dom'; import '@testing-library/jest-dom';
import { vi } from 'vitest'; import { vi } from 'vitest';
import { webcrypto } from 'node:crypto';
// Polyfill Web Crypto API for Node.js test environment
Object.defineProperty(global, 'crypto', {
value: webcrypto,
});
// Mock Tauri API // Mock Tauri API
vi.mock('@tauri-apps/api/core', () => ({ vi.mock('@tauri-apps/api/core', () => ({
invoke: vi.fn(), invoke: vi.fn(),
})); }));
// Mock Tauri runtime check // Mock Tauri runtime check - use alias path for consistency
vi.mock('../src/lib/tauri-gateway', () => ({ vi.mock('@/lib/tauri-gateway', () => ({
isTauriRuntime: () => false, isTauriRuntime: () => false,
getGatewayClient: vi.fn(), getGatewayClient: vi.fn(),
})); }));
@@ -718,14 +729,14 @@ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>"
- Modify: `desktop/src/lib/gateway-client.ts` - Modify: `desktop/src/lib/gateway-client.ts`
- Create: `desktop/tests/lib/gateway-security.test.ts` - Create: `desktop/tests/lib/gateway-security.test.ts`
**前置说明:**
- `isLocalhost` 函数已存在于 `gateway-storage.ts` (第 27-36 行)
- `gateway-client.ts` 已导入 `isLocalhost` (第 41 行)
- 现有代码仅输出警告 (第 209 行)，需要改为抛出错误
- [ ] **Step 1: 读取现有 gateway-client.ts WebSocket 连接逻辑** - [ ] **Step 1: 读取现有 gateway-client.ts WebSocket 连接逻辑**
Read file sections around WebSocket connection (lines 200-250 based on spec): Use Read tool to view `desktop/src/lib/gateway-client.ts` lines 200-220 to see current implementation.
```bash
# View the relevant section
head -n 250 g:/ZClaw_openfang/desktop/src/lib/gateway-client.ts | tail -n 100
```
- [ ] **Step 2: 写失败的测试 - WSS 强制** - [ ] **Step 2: 写失败的测试 - WSS 强制**