fix: P0-01/P1-01/P1-03 — account lockout, token revocation, optional display_name
Some checks failed
CI / Lint & TypeCheck (push) Has been cancelled
CI / Unit Tests (push) Has been cancelled
CI / Build Frontend (push) Has been cancelled
CI / Rust Check (push) Has been cancelled
CI / Security Scan (push) Has been cancelled
CI / E2E Tests (push) Has been cancelled

- P0-01: Account lockout now enforced via SQL-level comparison
  (locked_until > NOW()) instead of broken RFC3339 text parsing
- P1-01: Logout handler accepts JSON body with optional refresh_token,
  revokes ALL refresh tokens for the account (not just current)
- P1-03: Provider display_name is now optional, falls back to name

All 6 smoke tests pass (S1-S6).
This commit is contained in:
iven
2026-04-10 12:13:53 +08:00
parent 8163289454
commit b0e6654944
4 changed files with 60 additions and 32 deletions

View File

@@ -208,14 +208,18 @@ pub async fn login(
return Err(SaasError::Forbidden(format!("账号已{},请联系管理员", r.status)));
}
// M2: 检查账号是否被临时锁定
if let Some(ref locked_until_str) = r.locked_until {
if let Ok(locked_time) = chrono::DateTime::parse_from_rfc3339(locked_until_str) {
if chrono::Utc::now() < locked_time.with_timezone(&chrono::Utc) {
// M2: 检查账号是否被临时锁定 (直接在 SQL 层比较,避免时区解析问题)
let is_locked: bool = sqlx::query_scalar(
"SELECT locked_until IS NOT NULL AND locked_until > NOW() FROM accounts WHERE id = $1"
)
.bind(&r.id)
.fetch_one(&state.db)
.await
.unwrap_or(false);
if is_locked {
return Err(SaasError::AuthError("账号已被临时锁定,请稍后再试".into()));
}
}
}
if !verify_password_async(req.password.clone(), r.password_hash.clone()).await? {
// M2: 密码错误,递增失败计数
@@ -580,33 +584,49 @@ fn sha256_hex(input: &str) -> String {
pub async fn logout(
State(state): State<AppState>,
jar: CookieJar,
Json(req): Json<super::types::LogoutRequest>,
) -> (CookieJar, axum::http::StatusCode) {
// 尝试从 cookie 中获取 refresh token 并撤销
let jwt_secret = state.jwt_secret.expose_secret();
// 收集所有可用的 refresh token 来源
let mut tokens_to_check: Vec<String> = Vec::new();
// 来源 1: 请求 body 中的 refresh_token
if let Some(ref token) = req.refresh_token {
tokens_to_check.push(token.clone());
}
// 来源 2: cookie 中的 refresh_token
if let Some(refresh_cookie) = jar.get(REFRESH_TOKEN_COOKIE) {
let token = refresh_cookie.value();
if let Ok(claims) = verify_token_skip_expiry(token, state.jwt_secret.expose_secret()) {
let cookie_val = refresh_cookie.value().to_string();
if !tokens_to_check.contains(&cookie_val) {
tokens_to_check.push(cookie_val);
}
}
// 从任意有效的 refresh token 提取 account_id然后撤销该账户所有 token
for token in &tokens_to_check {
if let Ok(claims) = verify_token_skip_expiry(token, jwt_secret) {
if claims.token_type == "refresh" {
if let Some(jti) = claims.jti {
let now = chrono::Utc::now();
// 标记 refresh token 为已使用(等效于撤销/黑名单)
// 撤销该账户的所有 refresh token (不仅是当前的)
let result = sqlx::query(
"UPDATE refresh_tokens SET used_at = $1 WHERE jti = $2 AND used_at IS NULL"
"UPDATE refresh_tokens SET used_at = $1 WHERE account_id = $2 AND used_at IS NULL"
)
.bind(&now).bind(&jti)
.bind(&now)
.bind(&claims.sub)
.execute(&state.db)
.await;
match result {
Ok(r) => {
if r.rows_affected() > 0 {
tracing::info!(account_id = %claims.sub, jti = %jti, "Refresh token revoked on logout");
}
tracing::info!(account_id = %claims.sub, n = r.rows_affected(), "All refresh tokens revoked on logout");
}
Err(e) => {
tracing::warn!(jti = %jti, error = %e, "Failed to revoke refresh token on logout");
}
tracing::warn!(account_id = %claims.sub, error = %e, "Failed to revoke refresh tokens");
}
}
break; // 一次成功即可
}
}
}

View File

@@ -62,3 +62,9 @@ pub struct AuthContext {
pub struct RefreshRequest {
pub refresh_token: String,
}
/// 登出请求 (refresh_token 可选,不传则仅清除 cookie)
#[derive(Debug, Deserialize)]
pub struct LogoutRequest {
pub refresh_token: Option<String>,
}

View File

@@ -89,11 +89,13 @@ pub async fn create_provider(db: &PgPool, req: &CreateProviderRequest, enc_key:
String::new()
};
let display_name = req.display_name.as_deref().unwrap_or(&req.name);
sqlx::query(
"INSERT INTO providers (id, name, display_name, api_key, base_url, api_protocol, enabled, rate_limit_rpm, rate_limit_tpm, created_at, updated_at)
VALUES ($1, $2, $3, $4, $5, $6, true, $7, $8, $9, $9)"
)
.bind(&id).bind(&req.name).bind(&req.display_name).bind(&encrypted_api_key)
.bind(&id).bind(&req.name).bind(display_name).bind(&encrypted_api_key)
.bind(&req.base_url).bind(&req.api_protocol).bind(&req.rate_limit_rpm).bind(&req.rate_limit_tpm).bind(&now)
.execute(db).await.map_err(|e| SaasError::from_sqlx_unique(e, &format!("Provider '{}'", req.name)))?;

View File

@@ -21,7 +21,7 @@ pub struct ProviderInfo {
#[derive(Debug, Deserialize)]
pub struct CreateProviderRequest {
pub name: String,
pub display_name: String,
pub display_name: Option<String>,
pub base_url: String,
#[serde(default = "default_protocol")]
pub api_protocol: String,