fix(growth): Evolution Engine 穷尽审计 3CRITICAL + 3HIGH 全部修复
Some checks failed
CI / Lint & TypeCheck (push) Has been cancelled
CI / Unit Tests (push) Has been cancelled
CI / Build Frontend (push) Has been cancelled
CI / Rust Check (push) Has been cancelled
CI / Security Scan (push) Has been cancelled
CI / E2E Tests (push) Has been cancelled
Some checks failed
CI / Lint & TypeCheck (push) Has been cancelled
CI / Unit Tests (push) Has been cancelled
CI / Build Frontend (push) Has been cancelled
CI / Rust Check (push) Has been cancelled
CI / Security Scan (push) Has been cancelled
CI / E2E Tests (push) Has been cancelled
C-01: ExperienceExtractor 接入 ExperienceStore - GrowthIntegration.new() 创建 ExperienceExtractor 时注入 ExperienceStore - 经验持久化路径打通:extract_combined → persist_experiences → ExperienceStore C-02+C-03: 进化触发链路全链路接通 - create_middleware_chain() 注册 EvolutionMiddleware (priority 78) - MemoryMiddleware 持有 Arc<EvolutionMiddleware> 共享引用 - after_completion 中调用 check_evolution() → 推送 PendingEvolution - EvolutionMiddleware 在下次对话前注入进化建议到 system prompt H-01: FeedbackCollector loaded 标志修复 - load() 失败时保留 loaded=false,下次 save 重试 - 日志级别 debug → warn H-03: FeedbackCollector 内部可变性 - EvolutionEngine.feedback 改为 Arc<Mutex<FeedbackCollector>> - submit_feedback() 从 &mut self → &self,支持中间件 &self 调用路径 - GrowthIntegration.initialize() 从 &mut self → &self H-05: 删除空测试 test_parse_empty_response (无 assert) H-06: infer_experiences_from_memories() fallback - Outcome::Success → Outcome::Partial (反映推断不确定性)
This commit is contained in:
@@ -42,7 +42,7 @@ impl Default for EvolutionConfig {
|
||||
/// 进化引擎中枢
|
||||
pub struct EvolutionEngine {
|
||||
viking: Arc<VikingAdapter>,
|
||||
feedback: FeedbackCollector,
|
||||
feedback: Arc<tokio::sync::Mutex<FeedbackCollector>>,
|
||||
config: EvolutionConfig,
|
||||
}
|
||||
|
||||
@@ -50,7 +50,9 @@ impl EvolutionEngine {
|
||||
pub fn new(viking: Arc<VikingAdapter>) -> Self {
|
||||
Self {
|
||||
viking: viking.clone(),
|
||||
feedback: FeedbackCollector::with_viking(viking),
|
||||
feedback: Arc::new(tokio::sync::Mutex::new(
|
||||
FeedbackCollector::with_viking(viking),
|
||||
)),
|
||||
config: EvolutionConfig::default(),
|
||||
}
|
||||
}
|
||||
@@ -61,7 +63,9 @@ impl EvolutionEngine {
|
||||
let viking = experience_store.viking().clone();
|
||||
Self {
|
||||
viking: viking.clone(),
|
||||
feedback: FeedbackCollector::with_viking(viking),
|
||||
feedback: Arc::new(tokio::sync::Mutex::new(
|
||||
FeedbackCollector::with_viking(viking),
|
||||
)),
|
||||
config: EvolutionConfig::default(),
|
||||
}
|
||||
}
|
||||
@@ -144,18 +148,21 @@ impl EvolutionEngine {
|
||||
// -----------------------------------------------------------------------
|
||||
|
||||
/// 提交反馈并获取信任度更新,自动持久化
|
||||
pub async fn submit_feedback(&mut self, entry: FeedbackEntry) -> TrustUpdate {
|
||||
let update = self.feedback.submit_feedback(entry);
|
||||
pub async fn submit_feedback(&self, entry: FeedbackEntry) -> TrustUpdate {
|
||||
let mut feedback = self.feedback.lock().await;
|
||||
let update = feedback.submit_feedback(entry);
|
||||
// 非阻塞持久化:失败仅打日志,不影响返回值
|
||||
if let Err(e) = self.feedback.save().await {
|
||||
if let Err(e) = feedback.save().await {
|
||||
tracing::warn!("[EvolutionEngine] Failed to persist trust records: {}", e);
|
||||
}
|
||||
update
|
||||
}
|
||||
|
||||
/// 获取需要优化的进化产物
|
||||
pub fn get_artifacts_needing_optimization(&self) -> Vec<String> {
|
||||
pub async fn get_artifacts_needing_optimization(&self) -> Vec<String> {
|
||||
self.feedback
|
||||
.lock()
|
||||
.await
|
||||
.get_artifacts_needing_optimization()
|
||||
.iter()
|
||||
.map(|r| r.artifact_id.clone())
|
||||
@@ -163,8 +170,10 @@ impl EvolutionEngine {
|
||||
}
|
||||
|
||||
/// 获取建议归档的进化产物
|
||||
pub fn get_artifacts_to_archive(&self) -> Vec<String> {
|
||||
pub async fn get_artifacts_to_archive(&self) -> Vec<String> {
|
||||
self.feedback
|
||||
.lock()
|
||||
.await
|
||||
.get_artifacts_to_archive()
|
||||
.iter()
|
||||
.map(|r| r.artifact_id.clone())
|
||||
@@ -172,22 +181,21 @@ impl EvolutionEngine {
|
||||
}
|
||||
|
||||
/// 获取推荐产物
|
||||
pub fn get_recommended_artifacts(&self) -> Vec<String> {
|
||||
pub async fn get_recommended_artifacts(&self) -> Vec<String> {
|
||||
self.feedback
|
||||
.lock()
|
||||
.await
|
||||
.get_recommended_artifacts()
|
||||
.iter()
|
||||
.map(|r| r.artifact_id.clone())
|
||||
.collect()
|
||||
}
|
||||
|
||||
/// 获取反馈收集器的引用(用于高级查询)
|
||||
pub fn feedback(&self) -> &FeedbackCollector {
|
||||
&self.feedback
|
||||
}
|
||||
|
||||
/// 启动时加载已持久化的信任度记录
|
||||
pub async fn load_feedback(&mut self) -> Result<usize> {
|
||||
pub async fn load_feedback(&self) -> Result<usize> {
|
||||
self.feedback
|
||||
.lock()
|
||||
.await
|
||||
.load()
|
||||
.await
|
||||
.map_err(|e| zclaw_types::ZclawError::Internal(e))
|
||||
|
||||
@@ -501,7 +501,7 @@ fn infer_experiences_from_memories(
|
||||
pain_pattern: m.category.clone(),
|
||||
context: content.clone(),
|
||||
solution_steps: Vec::new(),
|
||||
outcome: crate::types::Outcome::Success,
|
||||
outcome: crate::types::Outcome::Partial,
|
||||
confidence: m.confidence * 0.7, // 降低推断置信度
|
||||
tools_used: m.keywords.clone(),
|
||||
industry_context: None,
|
||||
|
||||
@@ -137,13 +137,18 @@ impl FeedbackCollector {
|
||||
pub async fn save(&mut self) -> Result<usize, String> {
|
||||
// 首次保存前自动加载已有记录,防止丢失历史数据
|
||||
if !self.loaded {
|
||||
if let Err(e) = self.load().await {
|
||||
tracing::debug!(
|
||||
"[FeedbackCollector] Auto-load before save failed (non-fatal): {}",
|
||||
e
|
||||
);
|
||||
match self.load().await {
|
||||
Ok(_) => {
|
||||
self.loaded = true;
|
||||
}
|
||||
Err(e) => {
|
||||
// 加载失败时保留 loaded=false,下次 save 会重试
|
||||
tracing::warn!(
|
||||
"[FeedbackCollector] Auto-load before save failed, will retry next save: {}",
|
||||
e
|
||||
);
|
||||
}
|
||||
}
|
||||
self.loaded = true;
|
||||
}
|
||||
|
||||
let viking = match &self.viking {
|
||||
|
||||
Reference in New Issue
Block a user